Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified bedCreate API View to support bulk creating beds #1275

Merged
merged 34 commits into from
Aug 2, 2023
Merged

Modified bedCreate API View to support bulk creating beds #1275

merged 34 commits into from
Aug 2, 2023

Conversation

siddnikh
Copy link
Contributor

@siddnikh siddnikh commented Apr 27, 2023 •
edited
Loading

Required for ohcnetwork/care_fe#5413
Will solve #1274

We could have used ListSerializer for this particular purpose, but since we are bulk creating with only one difference in each object (their name is going to be - ), we don't need validation for each object.

Changes made:

  • Modified BedSerializer to have a 'number_of_beds' field which takes an integer value. If it is equal to 1, we proceed how we did previously, otherwise we bulk_create Bed objects.

@siddnikh siddnikh requested a review from a team as a code owner April 27, 2023 09:38
@siddnikh siddnikh mentioned this pull request May 16, 2023
Merged
@sainak sainak linked an issue Jun 24, 2023 that may be closed by this pull request
Add support for bulk creation of beds #1274
Closed
@ohcnetwork ohcnetwork deleted a comment from codecov-commenter Jul 1, 2023
@ohcnetwork ohcnetwork deleted a comment from sonarcloud bot Jul 1, 2023
sainak
sainak requested changes Jul 1, 2023
View reviewed changes
care/facility/api/serializers/bed.py Outdated Show resolved Hide resolved
care/facility/tests/test_bed_create.py Outdated Show resolved Hide resolved
care/facility/tests/test_multiple_bed_create.py Outdated Show resolved Hide resolved
@siddnikh siddnikh requested a review from sainak July 4, 2023 18:49
sainak
sainak requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing
Format the code using precommit

@siddnikh siddnikh requested a review from sainak July 7, 2023 18:32
sainak
sainak requested changes Jul 8, 2023
View reviewed changes
care/facility/api/viewsets/bed.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/bed.py Outdated Show resolved Hide resolved
@siddnikh siddnikh requested a review from sainak July 11, 2023 14:49
@siddnikh siddnikh requested a review from sainak July 11, 2023 15:16
@sainak sainak requested review from vigneshhari and removed request for a team July 11, 2023 15:19
vigneshhari
vigneshhari requested changes Jul 20, 2023
View reviewed changes
care/facility/api/viewsets/bed.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/bed.py Outdated Show resolved Hide resolved
care/facility/tests/test_bed_create.py Show resolved Hide resolved
care/facility/api/viewsets/bed.py Show resolved Hide resolved
care/facility/tests/test_bed_create.py Show resolved Hide resolved
@sainak
make requested changes
bef9a3a 
Signed-off-by: Aakash Singh <[email protected]>
Ashesh3
Ashesh3 approved these changes Jul 21, 2023
View reviewed changes
care/facility/tests/test_bed_create.py Outdated Show resolved Hide resolved
@vigneshhari vigneshhari merged commit fdfb798 into ohcnetwork:master Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg left review comments

@sainak sainak sainak approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for bulk creation of beds
6 participants
@siddnikh @Ashesh3 @gigincg @vigneshhari @rithviknishad @sainak