added referred_to_external field PatientConsultationDischargeSerializer

[sachdevavaibhav]

added referred_to_external field PatientConsultationDischargeSerializer

Associated Issue

• fixes PatientConsultationDischargeSerializer is not having referred_to_external field. #1429
• required by Referred to facility- discharge form care_fe#5407

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins @rithviknishad

[sachdevavaibhav]

@rithviknishad Kindly review it.

[rithviknishad]

@sachdevavaibhav lint CI is failing, make sure pre-commit is installed and ensure lints passes.

https://care-be-docs.coronasafe.network/local-setup/configuration.html#setting-up-pre-commit

[sachdevavaibhav]

@rithviknishad Done with formatting.

[sainak]

@vigneshhari this is a good time to migrate and remove referred_to foreign key
https://github.com/coronasafe/care/blob/b0eefd152511a390f759b41dac0cb7e27c9ee117/care/facility/models/patient_consultation.py#L92-L98

[sainak]

@sachdevavaibhav can you add some tests to validate whether this field is accepting correct inputs

[sachdevavaibhav]

@sachdevavaibhav can you add some tests to validate whether this field is accepting correct inputs

ya sure!

[vigneshhari]

@vigneshhari this is a good time to migrate and remove referred_to foreign key

https://github.com/coronasafe/care/blob/b0eefd152511a390f759b41dac0cb7e27c9ee117/care/facility/models/patient_consultation.py#L92-L98

This is more of an ops question @gigincg

[gigincg]

@sainak @vigneshhari And why is reffered_to deprecated?

[sainak]

@sainak @vigneshhari And why is reffered_to deprecated?

it was changed in #715, but I couldn't find the reference of the issue that requested the change

[sachdevavaibhav]

@sachdevavaibhav can you add some tests to validate whether this field is accepting correct inputs

ya sure!

@sainak I have a couple of questions:

• referred_to_external should accept only strings/null values right? And not integer etc.
• Should I create separate branch for tests or push them here only?

[sainak]

@sainak I have a couple of questions:

• referred_to_external should accept only strings/null values right? And not integer etc.

Yes

• Should I create separate branch for tests or push them here only?

You can include them in this pr

[sachdevavaibhav]

@sainak I have a couple of questions:

• referred_to_external should accept only strings/null values right? And not integer etc.

Yes

• Should I create separate branch for tests or push them here only?

You can include them in this pr

@sainak I have written a few test and found that its also accepting integers (may be its converting it to string values). Kindly review the test and should I also add some validation to the input?

[sachdevavaibhav]

@sainak I have a couple of questions:

• referred_to_external should accept only strings/null values right? And not integer etc.

Yes

• Should I create separate branch for tests or push them here only?

You can include them in this pr

@sainak I have written a few test and found that its also accepting integers (may be its converting it to string values). Kindly review the test and should I also add some validation to the input?

@sainak