-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medicines: replace in-memory search with pg full text search with GIN index #1439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will update tests |
sainak
approved these changes
Jul 6, 2023
rithviknishad
changed the title
Medicines: Remove in-memory search; add Gin Index and search on postgres itself
Medicines: Remove in-memory search; add GIN Index and search on postgres itself
Jul 6, 2023
rithviknishad
added a commit
to ohcnetwork/care_fe
that referenced
this pull request
Jul 6, 2023
sainak
approved these changes
Jul 6, 2023
sainak
approved these changes
Jul 6, 2023
Migrations tested on latest staging snapshot |
sainak
changed the title
Medicines: Remove in-memory search; add GIN Index and search on postgres itself
Medicines: replace in-memory search with pg full text search with GIN index
Jul 6, 2023
@sainak external_id was hidden too? |
Yeah we are using the id field for it right |
oh my bad; got confused |
This was referenced Jul 7, 2023
Closed
I tested in tunnel provided by @rithviknishad's and added multiple medicines to a patients but partial search is not giving expected results |
Alternate approach used. Completed via #1443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
MedibaseMedicinesTable
and support for in-memory search.generic
,name
,company
,cims_class
,contents
)Before: with the in-memory table (93ms ~ 128ms)
After: Search on Postgres with GIN Index and order by
SearchRank
(122ms ~ 170ms)(Postgres is not on the same machine; on a Linux machine on the same local network)
Index Size (~64 MB)
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins