Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark asset as down when middleware is down #1466

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Mark asset as down when middleware is down #1466

merged 3 commits into from
Jul 20, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jul 19, 2023

Proposed Changes

  • When the middleware server is down, all assets addressing that middleware are marked as down.
  • When the middleware does not report status of a particular asset, that asset is marked down.
  • If the middleware is down, we show a warning instead of an exception.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@Ashesh3 Ashesh3 requested a review from sainak July 19, 2023 15:50
@Ashesh3 Ashesh3 added the P1 High priority; urgent label Jul 20, 2023
@vigneshhari vigneshhari merged commit d9dd796 into master Jul 20, 2023
2 checks passed
@vigneshhari vigneshhari deleted the asset-monitor-task-fix branch July 20, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@sainak sainak sainak approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashesh3 @rithviknishad @sainak @vigneshhari