Skip validation if asset warranty date is not changed

[rithviknishad]

Proposed Changes

• Skip validation if asset warranty date is not changed

Associated Issue

• Fixes Warranty expiry in past is not allowing asset detail page to update #1500

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[rithviknishad]

@rithviknishad to add test cases

[Ashesh3]

This works fine. Though, would it be better quality wise if we merge this if with the latter one and only raise the Validation error in the below case? Then we'd not have to pop out data being sent by the user, since the warranty is same anyways and we just don't validate it, but it does make it a long if condition. What are your thoughts?

if self.instance
    and self.instance.warranty_amc_end_of_validity
    and self.instance.warranty_amc_end_of_validity != attrs["warranty_amc_end_of_validity"]
    and attrs.get("warranty_amc_end_of_validity")
    and attrs["warranty_amc_end_of_validity"] < datetime.now().date()
    :
        raise ValidationError(