-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added webpush on notes creation #1553
Conversation
PR looks good to me |
facility_users = FacilityUser.objects.filter(facility_id=patient.facility.id) | ||
for facility_user in facility_users: | ||
if facility_user.user.id != self.request.user.id: | ||
send_webpush(username=facility_user.user, message=json.dumps(message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sainak is this call deterministic, if not can we move it to the notification generator, it sends the webpush from the worker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is non-deterministic.
@Bhavik-ag can you move this to the notification generator?
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
+ Coverage 59.11% 59.17% +0.05%
==========================================
Files 207 205 -2
Lines 11264 11162 -102
Branches 1599 1590 -9
==========================================
- Hits 6659 6605 -54
+ Misses 4405 4356 -49
- Partials 200 201 +1
☔ View full report in Codecov by Sentry. |
Closing stale MR |
Changes
patient_id
andfacility_id
in the messagePATIENT_NOTE_ADDED