Adds Nurse user type and promote existing staffs to nurse

[aeswibon]

Proposed Changes

• Renamed "Staff" and "StaffReadOnly" to "Nurse" and "NurseReadOnly"
• Added new roles: "Staff" and "StaffReadOnly"

Associated Issue

• Issue: New user type "Nurse" care_fe#6240
• FE PR: Adds user type: Nurse and Nurse (readonly) care_fe#6464

Merge Checklist

• Tests added/fixed
• Update docs in /docs
• Linting Complete
• Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

[rithviknishad]

• You should rename the existing Staff type to Nurse type (10, "Nurse") and then create a new role for Staff. Effective order should be: 7: StaffReadOnly; 8: Staff; 9: NurseReadOnly; 10: Nurse

• The permissions for Nurse and Staff should be the same for now. However, in a later PR we can downgrade the permissions of Staff to have access only to Admin / Facility data and not Patient Data.

[codecov]

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (337d37d) 61.24% compared to head (3c6de8e) 61.33%.

Files	Patch %	Lines
care/facility/models/mixins/permissions/patient.py	11.76%	11 Missing and 4 partials ⚠️
...are/facility/models/mixins/permissions/facility.py	57.89%	7 Missing and 1 partial ⚠️
care/facility/models/daily_round.py	14.28%	4 Missing and 2 partials ⚠️
...are/facility/api/viewsets/patient_investigation.py	44.44%	5 Missing ⚠️
care/facility/api/serializers/patient_sample.py	20.00%	4 Missing ⚠️
care/facility/api/viewsets/patient_sample.py	0.00%	4 Missing ⚠️
care/facility/api/viewsets/file_upload.py	50.00%	3 Missing ⚠️
care/facility/models/mixins/permissions/base.py	25.00%	2 Missing and 1 partial ⚠️
care/facility/api/viewsets/notification.py	33.33%	2 Missing ⚠️
care/facility/api/viewsets/shifting.py	33.33%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
+ Coverage   61.24%   61.33%   +0.08%     
==========================================
  Files         208      208              
  Lines       11480    11496      +16     
  Branches     1650     1650              
==========================================
+ Hits         7031     7051      +20     
+ Misses       4177     4169       -8     
- Partials      272      276       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nihal467]

tested locally looks good to me

[rithviknishad]

@cp-coder the tests are failing

[nihal467]

@cp-coder clear the merge conflict

[rithviknishad]

For everywhere that authzn checks are done at serializer validate: Why are Authz checks done in the serializer validate? Shouldn't this be done by DRY Permissions?

[nihal467]

@aeswibon

[rithviknishad]

tests and lint checks are failing. also one of the earlier review is still not resolved

[aeswibon]

The PR is good for testing

[sainak]

closing in favor of #1819