Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release tracking on sentry #1590

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 11, 2023

Proposed Changes

  • adds automated release tagging on sentry.

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step
  • update secrets

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainak just a thought, since we are repeating the sentry step multiple times, we could consider using YAML reusable blocks with overrides right (for environment)?

eg: https://www.linode.com/docs/guides/yaml-anchors-aliases-overrides-extensions/#yaml-overrides

@sainak
Copy link
Member Author

sainak commented Sep 11, 2023

@sainak just a thought, since we are repeating the sentry step multiple times, we could consider using YAML reusable blocks with overrides right (for environment)?

eg: linode.com/docs/guides/yaml-anchors-aliases-overrides-extensions/#yaml-overrides

I'm planning to switch the deployment definitions with reusable workflow calls

@vigneshhari vigneshhari merged commit 912be96 into master Sep 11, 2023
6 checks passed
@vigneshhari vigneshhari deleted the sainak/feat/setry-release branch September 11, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants