Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return files with consent lists and consent filters #2255

Merged
merged 10 commits into from
Jul 13, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jun 8, 2024

Proposed Changes

  • Adds files directly to consent API (prevents need to call two endpoints from the client)
  • Adds the "has_consents" field to patient serializer
  • Adds consent filters

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added the P1 High priority; urgent label Jun 18, 2024
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the better way of doing is to have a bool variable on the consultation itself so that we don't have to do these operations for each patient

@shivankacker
Copy link
Member Author

@sainak do you mean creating a Boolean field on consultation model that is changed with consent operations?

@sainak
Copy link
Member

sainak commented Jun 18, 2024

@sainak do you mean creating a Boolean field on consultation model that is changed with consent operations?

yes

@shivankacker shivankacker requested a review from sainak June 23, 2024 20:51
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (cda75bb) to head (5b74301).
Report is 1 commits behind head on develop.

Files Patch % Lines
...e/facility/api/serializers/patient_consultation.py 75.00% 1 Missing and 1 partial ⚠️
care/facility/api/viewsets/patient.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2255      +/-   ##
===========================================
+ Coverage    63.48%   63.55%   +0.06%     
===========================================
  Files          238      238              
  Lines        13264    13298      +34     
  Branches      1886     1892       +6     
===========================================
+ Hits          8421     8451      +30     
- Misses        4490     4492       +2     
- Partials       353      355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/models/patient.py Outdated Show resolved Hide resolved
@shivankacker shivankacker requested a review from sainak June 24, 2024 17:56
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Show resolved Hide resolved
@shivankacker shivankacker requested a review from sainak July 2, 2024 12:56
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
@vigneshhari
Copy link
Member

@sainak need another review and we are good to go

@vigneshhari vigneshhari merged commit c9caff8 into develop Jul 13, 2024
11 checks passed
@vigneshhari vigneshhari deleted the consent-filters branch July 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants