GSoC - Doctor Notes Enhancement #2295
Open
+143
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UdaySagar-Git the backend test are failing |
|
@nihal467 fixed, can you please re run tests on this pr for confirmation |
sainak
requested changes
Jul 12, 2024
| replies = ReplyToPatientNoteSerializer(many=True, read_only=True) | ||
|
|
||
| def get_files(self, obj): | ||
| return FileUpload.objects.filter( |
There was a problem hiding this comment.
improvement: instead of doing this, save the files in a json array on the notes object which will have the file name and reference to the file
make sure to use json schema for the object
|
@sainak @rithviknishad can you review this once |
4 tasks
UdaySagar-Git
force-pushed
the
GSoC-Merged-DoctorNotes
branch
from
148e41a
to
db40d12
Compare
UdaySagar-Git
force-pushed
the
GSoC-Merged-DoctorNotes
branch
from
db40d12
to
f526d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a merge of all the pr's of Doctor Notes Enhancement
Frontend pr : ohcnetwork/care_fe#8016
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins