Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ABDM into Plug - Part 2/3 #2313

Open
wants to merge 85 commits into
base: develop
Choose a base branch
from
Open

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Jul 22, 2024

Important

This PR should only be merged a week after the PR #2161 is merged.

Note

For ease of reviewing, this (9d83712) was the only commit made after pre-plug-1

Proposed Changes

  • This pr is the 2nd half of the ABDM Pre plug.

In this pr, all the references of the abdm app in migrations are removed (replaced with squash migrations)

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.20%. Comparing base (4f6296a) to head (077a7ec).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2313   +/-   ##
========================================
  Coverage    64.20%   64.20%           
========================================
  Files          240      240           
  Lines        13562    13562           
  Branches      1947     1947           
========================================
  Hits          8707     8707           
  Misses        4496     4496           
  Partials       359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrations LGTM

@khavinshankar khavinshankar changed the title Convert ABDM into Plug - Part 2/2 Convert ABDM into Plug - Part 2/3 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants