Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a request time logging middleware #2361

Merged
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/middleware.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import logging
import time


class RequestTimeLoggingMiddleware:
def __init__(self, get_response):
self.get_response = get_response
self.logger = logging.getLogger("time_logging_middleware")

def __call__(self, request):
request.start_time = time.time()
response = self.get_response(request)
duration = time.time() - request.start_time
self.logger.info(f"Request to {request.path} took {duration:.4f} seconds")
return response
27 changes: 23 additions & 4 deletions config/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
import json
from datetime import datetime, timedelta
from pathlib import Path
from django.utils.translation import gettext_lazy as _

import environ
from authlib.jose import JsonWebKey
from django.utils.translation import gettext_lazy as _
from healthy_django.healthcheck.celery_queue_length import (
DjangoCeleryQueueLengthHealthCheck,
)
Expand Down Expand Up @@ -55,7 +55,6 @@
# https://docs.djangoproject.com/en/dev/ref/settings/#locale-paths
LOCALE_PATHS = [str(BASE_DIR / "locale")]


LANGUAGES = [
("en-us", _("English")),
("ml", _("Malayalam")),
Expand Down Expand Up @@ -201,6 +200,10 @@
"care.audit_log.middleware.AuditLogMiddleware",
]

# add RequestTimeLoggingMiddleware based on the environment variable
if env.bool("ENABLE_REQUEST_TIME_LOGGING", default=True):
MIDDLEWARE.insert(0, "config.middleware.RequestTimeLoggingMiddleware")

# STATIC
# ------------------------------------------------------------------------------
# https://docs.djangoproject.com/en/dev/ref/settings/#static-files
Expand Down Expand Up @@ -324,14 +327,30 @@
"verbose": {
"format": "%(levelname)s %(asctime)s %(module)s "
"%(process)d %(thread)d %(message)s"
}
},
"request_time": {
"format": "INFO %(asctime)s %(message)s",
"datefmt": "%Y-%m-%d %H:%M:%S",
},
},
"handlers": {
"console": {
"level": "DEBUG",
"class": "logging.StreamHandler",
"formatter": "verbose",
}
},
"time_logging": {
"level": "INFO",
"class": "logging.StreamHandler",
"formatter": "request_time",
},
},
"loggers": {
"time_logging_middleware": {
"handlers": ["time_logging"],
"level": "INFO",
"propagate": False,
},
},
"root": {"level": "INFO", "handlers": ["console"]},
}
Expand Down