archived spo2 field to archived_spo2 #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rithviknishad Fixed the migrations issue. Please check |
rithviknishad
requested changes
Aug 26, 2024
rithviknishad
approved these changes
Sep 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2397 +/- ##
========================================
Coverage 65.38% 65.38%
========================================
Files 242 242
Lines 13976 13976
Branches 1937 1937
========================================
Hits 9138 9138
Misses 4455 4455
Partials 383 383 ☔ View full report in Codecov by Sentry. |
sainak
requested changes
Sep 6, 2024
care/abdm/utils/fhir.py
Outdated
| @@ -304,7 +314,7 @@ def _observations_from_daily_round(self, daily_round): | |||
| ), | |||
| self._observation( | |||
| "SpO2", | |||
| {"value": daily_round.spo2, "unit": "%"}, | |||
| {"value": daily_round.archived_spo2, "unit": "%"}, | |||
There was a problem hiding this comment.
Suggested change
| {"value": daily_round.archived_spo2, "unit": "%"}, | |
| {"value": daily_round.ventilator_spo2, "unit": "%"}, |
we should use ventilator_spo2 in place of the unused field
cc: @khavinshankar
| @@ -116,7 +116,7 @@ class Command(BaseCommand): | |||
| "name": "VITALS", | |||
| "children": ( | |||
| {"name": "TEMPERATURE", "fields": ("temperature",)}, | |||
| {"name": "SPO2", "fields": ("spo2",)}, | |||
| {"name": "SPO2", "fields": ("archived_spo2",)}, | |||
There was a problem hiding this comment.
Suggested change
| {"name": "SPO2", "fields": ("archived_spo2",)}, |
we can drop this category, add it to the inactive types list
…ventilator_spo2' into archive-field-spo2-in-favour-of-ventilator_spo2
…-in-favour-of-ventilator_spo2
sainak
approved these changes
Sep 22, 2024
vigneshhari
approved these changes
Sep 23, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
renamed spo2 to
Associated Issue
spo2in favour ofventilator_spo2in the Daily Rounds model #2334Architecture changes
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins