Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable filtering inactive users by default #2529

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Oct 8, 2024

Proposed Changes

  • disable filtering inactive users by default
  • override user admin queryset to show soft deleted users

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@sainak sainak requested a review from a team as a code owner October 8, 2024 17:31
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.62%. Comparing base (e440d46) to head (c6a1ec1).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
care/users/admin.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2529      +/-   ##
===========================================
- Coverage    65.62%   65.62%   -0.01%     
===========================================
  Files          223      223              
  Lines        13393    13398       +5     
  Branches      1855     1856       +1     
===========================================
+ Hits          8789     8792       +3     
- Misses        4218     4222       +4     
+ Partials       386      384       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 7bdedf4 into develop Oct 15, 2024
4 checks passed
@vigneshhari vigneshhari deleted the sainak/remove-use-active-filter branch October 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants