-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dpg badge to readme #10134
base: develop
Are you sure you want to change the base?
Added dpg badge to readme #10134
Conversation
WalkthroughThe pull request introduces a Digital Public Goods (DPG) verification badge to the project's README.md file. The badge is added in two locations: one near the existing CARE logo and another in a new centered div at the end of the document. This addition highlights the project's recognition as a verified Digital Public Goods initiative since 2021, providing visual confirmation of its status and linking to the DPG website. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying care-fe with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
7-8
: Simplify the DPG badge implementation.While the badge placement is good, consider these improvements:
- Remove the extra space in "Since 2021"
- Use the official DPG badge instead of a custom shields.io implementation for consistency with their branding
- <a href="https://digitalpublicgoods.net/r/care"><img src="https://img.shields.io/badge/Verified-DPG%20(Since%20%202021)-3333AB?logo=data:image/svg%2bxml;base64,PHN2ZyB3aWR0aD0iMzEiIGhlaWdodD0iMzMiIHZpZXdCb3g9IjAgMCAzMSAzMyIgZmlsbD0ibm9uZSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KPHBhdGggZD0iTTE0LjIwMDggMjEuMzY3OEwxMC4xNzM2IDE4LjAxMjRMMTEuNTIxOSAxNi40MDAzTDEzLjk5MjggMTguNDU5TDE5LjYyNjkgMTIuMjExMUwyMS4xOTA5IDEzLjYxNkwxNC4yMDA4IDIxLjM2NzhaTTI0LjYyNDEgOS4zNTEyN0wyNC44MDcxIDMuMDcyOTdMMTguODgxIDUuMTg2NjJMMTUuMzMxNCAtMi4zMzA4MmUtMDVMMTEuNzgyMSA1LjE4NjYyTDUuODU2MDEgMy4wNzI5N0w2LjAzOTA2IDkuMzUxMjdMMCAxMS4xMTc3TDMuODQ1MjEgMTYuMDg5NUwwIDIxLjA2MTJMNi4wMzkwNiAyMi44Mjc3TDUuODU2MDEgMjkuMTA2TDExLjc4MjEgMjYuOTkyM0wxNS4zMzE0IDMyLjE3OUwxOC44ODEgMjYuOTkyM0wyNC44MDcxIDI5LjEwNkwyNC42MjQxIDIyLjgyNzdMMzAuNjYzMSAyMS4wNjEyTDI2LjgxNzYgMTYuMDg5NUwzMC42NjMxIDExLjExNzdMMjQuNjI0MSA5LjM1MTI3WiIgZmlsbD0id2hpdGUiLz4KPC9zdmc+Cg==" alt="DPG Badge"></a> + <a href="https://digitalpublicgoods.net/r/care"><img src="https://github.com/DPGAlliance/dpg-resources/blob/main/docs/assets/dpg-badge.png?raw=true" width="100" alt="Digital Public Goods Badge"></a>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Test
- GitHub Check: cypress-run (1)
- GitHub Check: OSSAR-Scan
- GitHub Check: CodeQL-Build
- GitHub Check: OSSAR-Scan
- GitHub Check: Cloudflare Pages: care-fe
🔇 Additional comments (2)
README.md (2)
157-162
: LGTM! Well-implemented footer badge.The implementation follows best practices:
- Uses the official DPG badge
- Includes proper security attributes for the external link
- Good spacing and alignment
Line range hint
1-162
: LGTM! Documentation structure is well-maintained.The DPG badge additions are well-placed and don't disrupt the existing documentation structure. The changes successfully achieve the PR's objective while maintaining the README's readability and organization.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~153-~153: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...th Service worker. The build is minified and the filenames include the hashes. **🚀...(COMMA_COMPOUND_SENTENCE_2)
[style] ~155-~155: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 4233 characters long)
Context: .... 🚀 Your app is ready to be deployed!
<a href...(EN_EXCESSIVE_EXCLAMATION)
CARE Run #4383
Run Properties:
|
Project |
CARE
|
Branch Review |
dpg-badge
|
Run status |
Passed #4383
|
Run duration | 02m 59s |
Commit |
2a48387ca8: Added dpg badge to readme
|
Committer | Shivank Kacker |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
View all changes introduced in this branch ↗︎ |
LGTM |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit