Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab #10200

shauryag2002 · 2025-01-26T11:22:45Z

Proposed Changes

Fixes UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation #9918
Fixed cypress command error.
Scroll Behavior on Data Fetch:
- Current Behavior: When scrolling up, the loading skeleton appears, and the component automatically scrolls back to the bottom.
- Fixed Behavior: The Loading... appears without forcing the component to scroll to the bottom.
Resizable Input Text Area Overflow:
- Current Behavior: The input text area can be expanded infinitely, causing layout overflow.
- Fixed Behavior: The text area now has a height limit, preventing overflow.
Unresponsive User Avatar and Username:
- Current Behavior: Clicking the user avatar or username does nothing.
- Fixed Behavior: Clicking the user avatar or username now correctly navigates to the user's profile.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced user navigation in Encounter Notes tab
- Added ability to click on user avatars and usernames to view profiles
- Improved message thread scrolling behavior
Bug Fixes
- Updated loading indicator for message fetching
- Refined scrolling logic for message threads
Chores
- Removed unnecessary ESLint comment in ResourceBoard component
- Updated Cypress command handling for better promise chain management

…in EncounterNotesTab

…sTab

…o shaurya/fix-notes

coderabbitai · 2025-01-26T11:22:53Z

Walkthrough

This pull request addresses multiple UI/UX improvements in the Encounters Notes Tab. The changes include modifying the Cypress command in commands.ts to return an expectation, updating the EncounterNotesTab component to enable user profile navigation by clicking avatars or usernames, and implementing a more controlled scrolling behavior for message threads. The modifications aim to enhance user interaction and resolve specific UI rendering and navigation issues.

Changes

File	Change Summary
`cypress/support/commands.ts`	Modified `getAttached` command to return the expectation result
`src/components/Resource/ResourceBoard.tsx`	Removed an ESLint comment line
`src/pages/Encounters/tabs/EncounterNotesTab.tsx`	- Added `useSlug` hook import - Implemented user profile navigation on avatar/username click - Added `scrollToBottom` state for controlled message scrolling - Updated loading indicator design

Assessment against linked issues

Objective	Addressed	Explanation
Scroll Behavior on Data Fetch	✅
Text Area Overflow	❓	No changes visible in the provided diff related to text area height
User Profile Navigation	✅

Possibly related PRs

Fixed the user management page cypress issue #9384: Modifications to Cypress test suite commands
Fixed importing structure & Modified Command Function in cypress #10113: Changes to cypress/support/commands.ts file structure

Suggested labels

needs review, changes required, needs testing

Suggested reviewers

nihal467
rithviknishad
Jacobjeevan

Poem

🐰 A Cypress command returns with grace,
Notes tab dances with a new embrace,
Avatars now lead the way,
To user profiles without delay,
Code hops forward with playful pace! 🚀

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-26T11:23:03Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`fb66af5`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a2419f6a45d6000802c538
😎 Deploy Preview	https://deploy-preview-10200--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/pages/Encounters/tabs/EncounterNotesTab.tsx (1)
Line range hint 1-1: Consider adding error boundaries.

While the implementation is solid, consider wrapping the component with an error boundary to gracefully handle runtime errors and provide fallback UI.
+import { ErrorBoundary } from '@/components/Common/ErrorBoundary';
+
 export const EncounterNotesTab = ({ encounter }: EncounterTabProps) => {
   // ... existing code ...
   return (
+    <ErrorBoundary fallback={<div>Error loading notes. Please try again.</div>}>
       <div className="flex h-[calc(100vh-12rem)]">
         {/* ... existing JSX ... */}
       </div>
+    </ErrorBoundary>
   );
 };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b053f6 and 0aebf3f.

📒 Files selected for processing (3)

cypress/support/commands.ts (1 hunks)
src/components/Resource/ResourceBoard.tsx (1 hunks)
src/pages/Encounters/tabs/EncounterNotesTab.tsx (10 hunks)

✅ Files skipped from review due to trivial changes (1)

src/components/Resource/ResourceBoard.tsx

🔇 Additional comments (5)

cypress/support/commands.ts (1)

65-65: LGTM! Important fix for Cypress command chain.

Adding the return statement ensures proper promise chain handling in the getAttached command, preventing potential race conditions in tests.

src/pages/Encounters/tabs/EncounterNotesTab.tsx (4)

124-128: LGTM! User profile navigation implementation.

The implementation correctly uses the facility slug for constructing the profile URL and adds click handlers to both avatar and username elements.

Also applies to: 146-150, 166-169

312-312: LGTM! Improved scroll behavior control.

The new scrollToBottom state variable and modified scroll logic effectively prevent unwanted scrolling while ensuring proper scroll behavior when needed (initial load, new messages).

Also applies to: 391-391, 408-415

630-630: LGTM! Fixed text area overflow.

The max-height-[150px] class effectively prevents infinite expansion while maintaining usability.

598-606: LGTM! Enhanced loading indicator UI.

The new loading indicator provides better visual feedback with centered positioning and proper contrast.

github-actions · 2025-01-28T12:14:11Z

👋 Hi, @shauryag2002,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Jacobjeevan · 2025-01-29T05:14:47Z

src/pages/Encounters/tabs/EncounterNotesTab.tsx

@@ -393,8 +405,14 @@ export const EncounterNotesTab = ({ encounter }: EncounterTabProps) => {

  // Scroll to bottom on initial load and thread change
  useEffect(() => {
-    if (messagesData && !messagesLoading && !isFetchingNextPage) {
+    if (


The issue with this approach is that it will just scroll to the top. Instead it should scroll to the very bottom of the newly loaded data, so navigating the conversation would be seamless for the user.

I'm currently stuck on implementing this properly. Right now, the scroll jumps to the top instead of smoothly moving to the bottom of the newly loaded data. Could you guide me on how to fix this in code and achieve the desired behavior?

I was looking into a few different approaches yesterday, but wasn't satisfied with the result 🤔 Let's remove the changes for scroll behavior for now, I'll take that up. Clear the merge conflicts so we can get this PR merged.

…o shaurya/fix-notes

nihal467 · 2025-02-03T08:28:11Z

@Jacobjeevan can you reply back the query

shauryag2002 added 8 commits January 12, 2025 00:10

Add user navigation from message items and enhance loading indicator …

05af782

…in EncounterNotesTab

Smooth scroll to pages element on EncounterNotesTab mount

6a8c171

revert date

a91e058

Add scroll-to-bottom functionality for new messages in EncounterNotesTab

21200d2

Remove unused smooth scroll effect for pages element in EncounterNote…

a78bf53

…sTab

Merge branch 'develop' of https://github.com/shauryag2002/care_fe int…

4f57530

…o shaurya/fix-notes

Update EncounterNotesTab.tsx

766d77a

Merge branch 'develop' of https://github.com/shauryag2002/care_fe int…

0aebf3f

…o shaurya/fix-notes

shauryag2002 requested a review from a team as a code owner January 26, 2025 11:22

coderabbitai bot reviewed Jan 26, 2025

View reviewed changes

shauryag2002 changed the title ~~Shaurya/fix notes~~ Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab Jan 26, 2025

Jacobjeevan added needs testing needs review labels Jan 28, 2025

github-actions bot added the merge conflict pull requests with merge conflict label Jan 28, 2025

Jacobjeevan requested changes Jan 29, 2025

View reviewed changes

Jacobjeevan added changes required and removed needs testing needs review labels Jan 29, 2025

Merge branch 'develop' of https://github.com/shauryag2002/care_fe int…

fb66af5

…o shaurya/fix-notes

nihal467 assigned Jacobjeevan Feb 3, 2025

Jacobjeevan removed their assignment Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab #10200

Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab #10200

shauryag2002 commented Jan 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 26, 2025 •

edited

Loading

coderabbitai bot left a comment

github-actions bot commented Jan 28, 2025

Jacobjeevan Jan 29, 2025 •

edited

Loading

shauryag2002 Feb 2, 2025

Jacobjeevan Feb 4, 2025

nihal467 commented Feb 3, 2025

Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab #10200

Are you sure you want to change the base?

Fix: UI Issues in Data Fetch Scroll, Text Area Overflow, and User Profile Navigation in notes tab #10200

Conversation

shauryag2002 commented Jan 26, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 26, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 26, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 28, 2025

Jacobjeevan Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

shauryag2002 Feb 2, 2025

Choose a reason for hiding this comment

Jacobjeevan Feb 4, 2025

Choose a reason for hiding this comment

nihal467 commented Feb 3, 2025

shauryag2002 commented Jan 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 26, 2025 •

edited

Loading

Jacobjeevan Jan 29, 2025 •

edited

Loading