Resolve Military Time Display and Schedule Exception Issue on Mobile

[modamaan]

Proposed Changes

• Fixes Mobile UI Shows Military Time and Fails to Add Schedule Exception #10781
• Change 1
• Change 2
• More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features
  • Updated the scheduling exception interface to use 60-second increment steps for time inputs, making it easier to select precise time values.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the CreateScheduleExceptionSheet component by adding a step attribute with a value of 60 to two <Input> components of type time. This adjustment ensures that the time inputs increment in 60-second intervals while maintaining their existing bindings and disable logic. There are no modifications to the underlying logic or exported entities.

Changes

File	Change Summary
src/.../CreateScheduleExceptionSheet.tsx	Added step={60} on two <Input> components for time input control

Suggested labels

needs review, needs testing

Suggested reviewers

• rithviknishad

Poem

Hopping through code with carrot delight,
I found a change that felt just right.
A gentle step of sixty in time,
Makes inputs dance in rhythmic rhyme.
With joyful hops and ASCII cheer,
This rabbit celebrates the tweak so dear!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	13b6ea0
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67beb72bf3eeea0008cf8c03
😎 Deploy Preview	https://deploy-preview-10804.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx (1)

266-272: LGTM! Consider adding ARIA labels for better accessibility.

The addition of step="60" effectively resolves the military time display issue by enforcing minute-level precision. This aligns well with the form's "HH:mm" format validation.

Consider adding ARIA labels to improve accessibility:

 <Input
   type="time"
   step="60"
+  aria-label={t("exception_start_time")}
   {...field}
   disabled={unavailableAllDay}
 />

 <Input
   type="time"
   step="60"
+  aria-label={t("exception_end_time")}
   {...field}
   disabled={unavailableAllDay}
 />

Also applies to: 285-291

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c269220 and 42d0591.

📒 Files selected for processing (1)

• src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: cypress-run (1)

🔇 Additional comments (3)

src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx (3)

63-95: LGTM! Robust validation logic.

The form schema properly validates military time format and ensures correct time ranges, with appropriate handling of the all-day unavailability case.

---

137-145: LGTM! Clean state management.

The form state management properly handles time field updates and resets, with appropriate handling of the all-day unavailability toggle.

---

1-38: LGTM! Well-structured component.

The component follows best practices with clear separation of concerns, proper use of design system components, and internationalization support.

Also applies to: 158-319