-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Notifications for Facility Cover Image Deletion #7609
Fix Notifications for Facility Cover Image Deletion #7609
Conversation
@AnkurPrabhu is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rithviknishad we already had notification for deletion its just that due to re-renders it does not show it. this should fix it |
<CareIcon icon="l-save" className="text-lg" /> | ||
)} | ||
<span> | ||
{isDeleting ? `${t("Deleting")}...` : `${t("delete")}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using capital key Deleting
? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will change it to deleting
{isDeleting ? ( | ||
<CareIcon | ||
icon="l-spinner" | ||
className="animate-spin text-lg" | ||
/> | ||
) : ( | ||
<CareIcon icon="l-save" className="text-lg" /> | ||
)} | ||
<span> | ||
{isDeleting ? `${t("Deleting")}...` : `${t("delete")}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have something simlar to disabling cover that disables the entrie action on save?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just used what we already do for upload we just wanted a re-render to happen here in order to fix the bug, should i remove it ?
pls take a look @bodhish |
LGTM |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnkurPrabhu can u also move the constants (that doesn't depend on any state) outside the function
@khavinshankar can you explain as in what do you mean by constants here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnkurPrabhu some minor suggestions,
Can you please move these constants out of the component (these doesn't depend on any state or props)
const FACING_MODE_USER = "user";
const FACING_MODE_ENVIRONMENT = { exact: "environment" };
const videoConstraints = {
width: 1280,
height: 720,
facingMode: "user",
};
const LaptopScreenBreakpoint = 640;
} | ||
}, | ||
null, | ||
() => { | ||
Notification.Error({ | ||
msg: "Network Failure. Please check your internet connectivity.", | ||
}); | ||
setIsUploading(false); | ||
setIsProcessing(false); | ||
}, | ||
); | ||
|
||
await sleep(1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnkurPrabhu can remove this and check if there is any sideeffects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khavinshankar can we connect on slack today i had some doubts.
LGTM |
@rithviknishad @AnkurPrabhu Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
screenshot: