-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 404 page on edit route #7727
Adding 404 page on edit route #7727
Conversation
@Aryanshu919 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Aryanshu919 clear the merge conflict |
@nihal467 Done. Could you review it? |
@@ -100,7 +100,7 @@ const TextFormField = forwardRef((props: TextFormFieldProps, ref) => { | |||
); | |||
const _trailing = | |||
trailing === trailingFocused ? ( | |||
<div className="absolute inset-y-0 right-0 flex items-center pr-3"> | |||
<div className="relative inset-y-0 right-0 flex items-center pr-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed? Unrelated to the issue being solved right?
Feel free to create a separate issue if this solves an issue 😄
"/facility/:facilityId/patient/:patientId/consultation/:id/edit": () => ( | ||
<Error404 /> | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention of the issue is, that any invalid links should show a 404 page, not just /edit
.
This can be achieved by having a fallback to Error404 component if none of the URLs has matched with the current URL.
Proposed Changes
Redirecting the user to an existing 404 page whenever user go on "/edit" route.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist