Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC - Doctor Notes Enhancement #8016

Open
wants to merge 112 commits into
base: develop
Choose a base branch
from

Conversation

UdaySagar-Git
Copy link
Contributor

@UdaySagar-Git UdaySagar-Git commented Jun 11, 2024

This PR is created to track my progress on the GSoC project (#7159) and to merge all PRs related to Doctor notes.

Backend RR: ohcnetwork/care#2295

walk_through_discussion_notes_enhancement.mp4
  • Reply feature in doctore notes
  • Profile image support for a user
  • Markdown Support

File Upload Option

  • support for camera captures
  • support for audio recording
  • support for uploading files
  • file preview support foNr uploaded files

User Tagging Mechanism

  • support for tagging a user (mentions)
  • Filtering of users and support for selecting users with keyboard arrows
  • sending notifications upon mention
  • hover card to show user details

  • Show Uploaded files under patient consultation page

@UdaySagar-Git UdaySagar-Git requested a review from a team as a code owner June 11, 2024 13:40
Copy link

vercel bot commented Jun 11, 2024

@UdaySagar-Git is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@UdaySagar-Git UdaySagar-Git marked this pull request as draft June 11, 2024 13:41
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 18989ea
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c65f3b24e85800085ed64f
😎 Deploy Preview https://deploy-preview-8016--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

<>
<div className="flex flex-1 items-center justify-center rounded-lg">
<img
src={imgSrc}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 19, 2024
@UdaySagar-Git
Copy link
Contributor Author

@rithviknishad can you please remove stale label

Copy link

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 26, 2024
@UdaySagar-Git
Copy link
Contributor Author

UdaySagar-Git commented Oct 2, 2024

@nihal467 can you review it once?

walk_through_discussion_notes_enhancement.mp4

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 2, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 3, 2024

@UdaySagar-Git can you do the below-mentioned things for review :

  • fix the lint and test in the co-related backend PR
  • The doctor notes related cypress test is failing in the frontend, can you attach the screenshot of the test passing in your local

@nihal467 nihal467 added changes required and removed needs testing Deploy-Failed Deplyment is not showing preview labels Oct 3, 2024
@UdaySagar-Git
Copy link
Contributor Author

@nihal467 fixed related tests

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 9, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 11, 2024

Bug

image

  • the thread view and default view is the doctor notes dedicated page view is breaking UI

image

  • the tooltip of attachment is clipping in the normal full view

Enhancement

image

  • the editor will be used by non-tech savy people, for them, when we click bold, rather than "*" , its better to make the text bold itself
  • when the word is getting bold, keep the related icon, as well as in primary colour to show its active

image

  • when drag select multi line para and try to apply order list, it is being only applied to the first line of the para

image

  • add a validation to the hyperlinking related to fields in the pop-up since its accepting empty input

@UdaySagar-Git
Copy link
Contributor Author

UdaySagar-Git commented Oct 13, 2024

  • the editor will be used by non-tech savy people, for them, when we click bold, rather than "*" , its better to make the text bold itself
  • when the word is getting bold, keep the related icon, as well as in primary colour to show its active

@khavinshankar @bodhish @nihal467

There is a preview section (clicking on it shows how the markdown will appear in the UI). However, if we want a full-fledged live markdown editor, we need to rely on an external package. Achieving this natively would make the code unmaintainable, especially since the execCommand() method, previously used for this, has been deprecated and there is no straightforward alternative.

Here is an implementation of a rich text editor using different libraries: https://github.com/UdaySagar-Git/Text-Editor (Lexical is missing). Please let me know if you're okay with adding a package, and I will make a follow-up PR for this. However, I think relying on plain markdown is also a valid approach (this is how WhatsApp handles it, and users are very familiar with that atleast for just bold and italic).

image
  • the thread view and default view is the doctor notes dedicated page view is breaking UI
  • the tooltip of attachment is clipping in the normal full view
  • when drag select multi line para and try to apply order list, it is being only applied to the first line of the para
  • add a validation to the hyperlinking related to fields in the pop-up since its accepting empty input

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
Copy link

👋 Hi, @UdaySagar-Git,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 17, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required Deploy-Failed Deplyment is not showing preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.