Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added privacy toggle for a consultation bed and lock camera controls when used by a user #8666

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Added privacy toggle for a consultation bed and lock camera controls when used by a user #8666

wants to merge 11 commits into from

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar requested a review from a team as a code owner September 30, 2024 04:07
@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 89c4bb0
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670e40df2d41ba00084f0e23
😎 Deploy Preview https://deploy-preview-8666--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar mentioned this pull request Sep 30, 2024
Open
@cypress Cypress
Copy link

cypress bot commented Sep 30, 2024 •
edited
Loading

CARE    Run #3660

Run Properties:  status check passed Passed #3660  •  git commit 89c4bb04bb: Added privacy toggle for a consultation bed and lock camera controls when used b...
Project CARE
Run status status check passed Passed #3660
Run duration 03m 22s
Commit git commit 89c4bb04bb: Added privacy toggle for a consultation bed and lock camera controls when used b...
Committer Khavin Shankar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@nihal467 nihal467 added waiting for related PR a co-related detail PR is under construction and removed waiting for related PR a co-related detail PR is under construction labels Sep 30, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 30, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89c4bb0
Status: ✅  Deploy successful!
Preview URL: https://23a0994d.care-fe.pages.dev
Branch Preview URL: https://privacy-consultation-bed.care-fe.pages.dev

View logs

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 1, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 1, 2024 •
edited by khavinshankar
Loading

image

  • Even though the camera feed is live, there is a frontend notification thrown mentioning that the camera is locked

image

  • assetbed API is failing and we are not able to create a new camera preset

image

  • Currently, the camera feed component is not showing multiple icons to represent that there are multiple users are viewing the feed

image

  • when a user request for a camera access, it is get auto-granted without notification

@nihal467
Copy link
Member

nihal467 commented Oct 1, 2024

@khavinshankar the basic functionality is failing across, can you fix everything and attach a QA video

@khavinshankar
Copy link
Member Author

@nihal467 I have added a demo video explaining the feature https://drive.google.com/file/d/1hPv1wdme2n87dFL95KwoDwAuOSQPt0pd/view?usp=sharing

Even though the camera feed is live, there is a frontend notification thrown mentioning that the camera is locked

This is an expected notification but the content was misleading, so I updated the wording.

assetbed API is failing and we are not able to create a new camera preset

I was not able to replicate this, this could have happened due to the backend having migrations from other PRs, please removing the existing database and creating a new one with fresh migrations.

Currently, the camera feed component is not showing multiple icons to represent that there are multiple users are viewing the feed

Can we make this as a new good-first issue, so that the basic version of patient privacy and camera control locking can be merged.

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2024 •
edited by khavinshankar
Loading

image

  • whenever we open, it still sends two notification in the frontend, i think its due to the operate_asset api is been called from frontend, can you check that issue, rest looks good

@nihal467
Copy link
Member

nihal467 commented Oct 9, 2024

image

@khavinshankar each time when i open the camera and viewing this notification kind of weird, but we can think of a enhancement once the PR is merged, open an issue and look for a better UX

@nihal467
Copy link
Member

nihal467 commented Oct 9, 2024

except the previous comment, rest LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 13, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 15, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivankacker shivankacker shivankacker approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict needs review tested waiting for backend
Projects
None yet
Milestone
No milestone
4 participants
@khavinshankar @nihal467 @shivankacker @rithviknishad