Facility image issue is Fixed

[NikhilGolla72]

Users can now upload facility cover image in the facility registration form itself by enabling the checkbox option provided in the 3rd step of facility registration/

@ohcnetwork/care-fe-code-reviewers

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	f71cfbe
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/670be2be94bfe60008472764
😎 Deploy Preview	https://deploy-preview-8744--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

👋 Hi, @NikhilGolla72,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[nihal467]

@NikhilGolla72 Adding it to staff capacity is not bringing any value to the users, so closing this PR, as this is an irrelevant change, feel free to work on any open issues in the care_fe

[nihal467]

@NikhilGolla72 Sorry for the inconvenience, bro, but make sure you link an issue(#7297) to your PR so that, during the review, we can see which issue you're trying to address. The PR heading is not clearly communicating what the PR is about. Could you make the following changes: :

1. Mention the issue in the PR and give it a proper heading based on the PR.
2. From the issue and the slack thread, I'm getting the understanding that you need to make it an optional fourth step after the staff capacity. However, what you’ve done is added a checkbox in the staff capacity step, which isn’t ideal because the cover image is not part of staff capacity. So, keeping it as a fourth step would be better.

[NikhilGolla72]

@nihal467 sorry for the misunderstanding I caused,I am new to the open source contribution and I didn't know the fomat to submit a PR.I will follow the format from now on for sure and also I will make it as a 4th step

and also I want to ask about the cypress attempt 2 which is caused by not identifying the " div#map-close " under 10000ms .Can I change it 20000ms to that it may be solve this cypress test issue?

[nihal467]

@NikhilGolla72 can you share the screenshot of the cypress dashboard , to know what is exactly

[NikhilGolla72]

@nihal467

[nihal467]

@NikhilGolla72 run the cypress locally and try to debug it, use the command "npx cypress open" and check whether its passing in your local to not

[NikhilGolla72]

@nihal467



The same error for every file in the specs

[rithviknishad]

Looks like your local cypress is unable to connect to your local backend. Are you sure ur local backend is accessible in that URL?

[NikhilGolla72]

@rithviknishad i think this is what causing the problem

i tried fixing it many times but still i am getting the same error, i tried to reinstall @types/cypress and verified type definition files but i dont understand what is causing the problem

[rithviknishad]

create a separate issue, this issue seems to be present in develop branch too.

[NikhilGolla72]

@rithviknishad i just want to confirm, is this issue present in the develop branch itself?and i can't clear it by fixing my tsconfig file in local?

[nihal467]

@NikhilGolla72 can you log in manually, and verify that you are connected to your local backend? Are you able to see the dummy data ?

[NikhilGolla72]

@nihal467 i am working on the care_fe repo which doesnt has any Makefile so i couldnt run the makeup command to load the dummy data but i am able to run the backend using docker desktop.Could you please tell me what is causing the error in tscong file and also in cypress attempt 2

[nihal467]

Nikhil from the screenshot, you are not doing the backend configuration properly

Note: CARE is not a monorepo; you can access the frontend at https://github.com/ohcnetwork/care_fe and the backend at https://github.com/ohcnetwork/care.

steps to run the docker :

1. Clone the backend repo: https://github.com/ohcnetwork/care (backend)

2. now since you are using the docker app, open the vs code and verify you are in the correct branch

3. run docker compose -f docker-compose.yaml -f docker-compose.local.yaml up -d in your vs code panel

4. now open the docker app and check all the containers are running

5. now open the celery container and view the log, verify all the migration is completed

6. open the localhost:9000 and you will be able to view a similar page as below:
   

7. once the entire backend is up, run the command in vs code for loading the dummy data docker exec care-backend-1 python manage.py load_dummy_data

Once all the steps are followed properly, your backend is fully up.

Connect the frontend to the backend:

• in the frontend , open the .env file and replace the REACT_CARE_API_URL=https://careapi.ohc.network to REACT_CARE_API_URL=http://localhost:9000

[NikhilGolla72]

@nihal467 Hi nihal, i am working on setup up the backend in the local, but can i know how the issue with Github actions cypress test is related to my backend setup?The change in my PR is only modifiying the Facilitycreate.tsx file and it's working fine.

[nihal467]

@NikhilGolla72

• Setting up the local backend is necessary to run Cypress locally, replicate the failure mentioned in the GitHub action, and fix it.
• You have modified the facility creation workflow by adding a 4th step into it, which means there are already existing tests in that workflow that are breaking due to your PR modifications. Therefore, you also need to update the existing Cypress tests in your PR.