Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dosage heading is misaligned in the prescription module #8645 #8751

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Sulochan-khadka
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner October 9, 2024 19:33
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 8efe2de
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6706da7935c081000892db42
😎 Deploy Preview https://deploy-preview-8751--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c6bbea2
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670e7b18fadbd0000874d956
😎 Deploy Preview https://deploy-preview-8751--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sulochan-khadka
Copy link
Contributor Author

Added elipsis as it seemed a bit clean and aligned.
Screenshot 2024-10-10 at 1 04 11 AM

Whereas with wrapping it in new line, the width adjustment seems somewhat wrong(alignment):
Screenshot 2024-10-10 at 1 04 53 AM

Do let me know in case of any changes.

@Sulochan-khadka
Copy link
Contributor Author

@nihal467 @rithviknishad kindly review the PR .

@nihal467
Copy link
Member

image

  • keep everything in the center , in your current solution heading , excess indicator medicine and medicine with limited indicator, all are in multiple alignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dosage heading is misaligned in the prescription module
3 participants