Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the UI of events log and switch tab #8825

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JOSHIK27
Copy link
Contributor

@JOSHIK27 JOSHIK27 commented Oct 18, 2024

Proposed Changes

  • Fixes Modify the UI of events log switch tab #8286
  • Erased the logic for both sort buttons which were initially present in child components i.e (eventlist and dailroundslist) and brought the logic to parent component which was rendering child components.
  • In the parent component, 2 query state variables for both sort buttons were created and passed them as props to child components. And DailyRoundsSortDropdown (which is popover) component is created in the parent component.
  • DailyRoundsSortDropdown styling was fixed as we just need to display filter icon (not text)
  • For eventlist sort button, a new popover was created to make it look exactly same as DailyRoundsSortDropdown popover.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@JOSHIK27 JOSHIK27 requested a review from a team as a code owner October 18, 2024 11:46
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 41a3e43
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671266adcae75d0008d059de
😎 Deploy Preview https://deploy-preview-8825--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JOSHIK27 JOSHIK27 changed the title Fixes#8286 Modified the UI of events log and switch tab Oct 18, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the PR template and checklist.

@JOSHIK27
Copy link
Contributor Author

Please follow the PR template and checklist.

I have added proposed changed in the pr template. can you check if everything is ok or if anything needs to changed @rithviknishad ?

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is gitignored. why was it checked in?

Copy link
Contributor Author

@JOSHIK27 JOSHIK27 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i merged develop branch with my feature branch this was in unstaged files of git. I added it to staging area and then pushed it. Thats surprising.

The feature branch had this file for very long time, when i merged it with develop this was added to staging area. It was my mistake. Shall i delete this file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the UI of events log switch tab
3 participants