Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes greyed out 'Active Manage Bed' button in Location Management Page #8814 #8827

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

abhip161
Copy link

Proposed Changes

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@abhip161 abhip161 requested a review from a team as a code owner October 18, 2024 13:54
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 6460119
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67127e36e8c8860008b994a5
😎 Deploy Preview https://deploy-preview-8827--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the proper fix?

@@ -289,7 +289,7 @@ const Location = ({
border
className={cn(
"mt-3 flex w-full items-center justify-between",
totalBeds != null && "opacity-50",
totalBeds != null && "opacity-100",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
totalBeds != null && "opacity-100",
totalBeds == null && "opacity-50",

Copy link
Author

@abhip161 abhip161 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rithviknishad
if opacity-50 manage bed button will greyed out

if you want
opacity behaves correctly based on the totalBeds condition ??

When totalBeds is null, the button will have opacity-50, making it look greyed out.

When totalBeds has a value, the button will display with opacity-100, appearing fully visible.

@rithviknishad rithviknishad added the question Further information is requested label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Active Manage Bed button in Location Management Page is greyed out
3 participants