Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Sonner for toast notifications #9405
Switch to Sonner for toast notifications #9405
Changes from 5 commits
5c0f052
bb44c6a
a828352
9434c27
0761bc7
c3b3b8d
cbd8d11
05702ac
63c3a83
fc2efc2
7007e04
e1d536f
0ba432f
bfbcd97
603b1b8
7754bbd
86d171b
94a1d53
7a0874e
809900e
9a085cf
0177534
de2ff2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Based on the analysis of z-index values in the codebase and Sonner's configuration:
src/style/index.css
App.tsx
but lacks explicit z-index configurationTo resolve potential overlay issues:
zIndex
prop to the Toaster component with a value higher than 100000🔗 Analysis chain
LGTM! Verify z-index configuration with Sonner.
The import change looks good. However, based on the PR comments about toast notifications being overlaid by other elements, ensure Sonner's z-index configuration is properly set.
Let me check the Sonner toast configuration in the codebase to ensure proper z-index setup.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 755
Script:
Length of output: 382
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename Error function to avoid shadowing global Error.
The function name 'Error' shadows the built-in Error object. Consider renaming it to be more specific.
📝 Committable suggestion
🧰 Tools
🪛 Biome (1.9.4)
[error] 56-56: Do not shadow the global "Error" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add expand prop. Let's have the notifications expanded by default, while the hover state looks nice, I don't think it will work (esp for mobile screens).
And look at tests like Rithvik mentioned above 👍