Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : View Retention in Users Tab After Navigation #9485
Fix : View Retention in Users Tab After Navigation #9485
Changes from all commits
51a053e
79fafe7
fb3a446
8af90dd
71ac706
db15f8b
2430231
e0eb9d8
a939247
c7808ad
249be67
f785378
b14a320
ffa3559
d7f0669
3a62c2f
609f723
0724ab4
1efe9f5
91765fd
1ac3800
84b32c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
View preferences should be cleared during logout
The
useView
hook stores view preferences in localStorage, but these preferences are not cleared during logout. While the auth-related tokens are properly cleared in thesignOut
function (AuthUserProvider.tsx
), the view preferences persist across sessions. To maintain proper session isolation:signOut
function inAuthUserProvider.tsx
ViewCache.ts
utility to manage view-related storage operationsExample locations that need attention:
src/Providers/AuthUserProvider.tsx
: Add view preference clearing to thesignOut
functionsrc/Utils/ViewCache.ts
: Consider adding aclearAll
utility if not already present🔗 Analysis chain
Verify view retention behavior across user sessions
The implementation stores view preferences in localStorage. To prevent view preferences from persisting across different user sessions, ensure the storage is cleared on logout.
Also applies to: 43-43
Let me search for the implementation of the useView hook to understand how it handles storage.
Let me check how the auth state and logout is handled to see if localStorage is properly cleared.
Let me check if there's a utility to clear view preferences and if it's being used during logout.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 18775
Script:
Length of output: 500
Script:
Length of output: 4325
Script:
Length of output: 137