Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED: Text overflows in the user management card details #9532 #9541

Closed
wants to merge 8 commits into from
Closed

FIXED: Text overflows in the user management card details #9532 #9541

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03161e0
FIXED: Text overflows in the user management card details, and text o…
piyushyadav0191 Dec 23, 2024
ef780bd
FIXED: Text overflows in the user management card for only name
piyushyadav0191 Dec 23, 2024
ce5e52c
chore: added tooltip to name while maintaining original code
piyushyadav0191 Dec 24, 2024
e3e3f5c
chore: truncated the name if found long
piyushyadav0191 Dec 24, 2024
294bbc7
chore: truncated the name if found long(in rem)
piyushyadav0191 Dec 24, 2024
cf114a7
size ratio: 7rem seems to be perfect on different scrns
piyushyadav0191 Dec 24, 2024
88b3914
chore: refined tooltip UI
piyushyadav0191 Dec 27, 2024
968eba3
Update src/components/Users/UserListAndCard.tsx
piyushyadav0191 Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Users/UserListAndCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const getNameAndStatusCard = (
<TooltipTrigger asChild>
<h1
id={`name-${user.username}`}
className="text-base font-bold"
className="text-base font-bold truncate max-w-[200px]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use rem values over pixels. pixels can behave differently on different DPIs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

>
{formatName(user)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The tooltip works, however the long name is still displayed; issue isn't solved.

Copy link
Author

@piyushyadav0191 piyushyadav0191 Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either, I can truncate or can decide some width or height to that popover

Copy link
Contributor

@Jacobjeevan Jacobjeevan Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either, I can truncate or can decide some width or height to that popover

Truncate the name on the card (Tooltip trigger). Tooltip Content is fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</h1>
Expand Down