[fix] Fix typos #1692
Closed
[fix] Fix typos #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fixing all the typos in this repository, I discovered that these comments don't actually make sense to me. If we already touch these comments to fix the typos, we should make sure they actually make sense.
Fix this typo first manually because otherwise `typos -w` would correct it to "processes" ... we however want the singular.
While the typos spell checker could report these typos it couldn't automatically fix them since there are multiple possible corrections, e.g. `agains` could be `again` or `against`. So this commit fixes these typos manually.
|
OK wow, we actually have a spell checker for the But not one for the code This change is good as long as it passes the CI -- I sent you an invite so you have permissions to run through the CI |
|
Ah is #1038 the relevant issue? I accepted the invite but the CI is still failing in the other PR after a force push because "$TOIL_KEY not set" and manually rerunning all jobs also didn't do the trick. What do I have to do to make it work? |
Merged
|
Closing in favor of #1693 (since GitHub doesn't let you update the source branch of a PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the followup PR for #1691 (the first commit here actually belongs to that other PR, this PR will be rebased once that other PR has been merged).
The typos were found with the typos spell checker.
The 1st fix commit was created manually, the fixes in the 2nd fix commit were done by
typos -w(but all manually reviewed), the fixes in the 3rd fix commit were again done manually.I'm planning on introducing the
typosspell checker into the CI in a followup PR to prevent the accidental introduction of known typos in the future.