Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Check if GLOB_PERIOD exists #2207

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Conversation

Melkor333
Copy link
Collaborator

As discussed briefly in Zulip. Not sure what a "peoper" solution is, defining GLOB_PERIOD as 0 is probably wrong :)

@andychu andychu changed the base branch from master to soil-staging January 5, 2025 17:38
@andychu andychu merged commit 1aeec95 into soil-staging Jan 5, 2025
18 checks passed
@andychu
Copy link
Contributor

andychu commented Jan 5, 2025

OK thanks -- actually I think it should never be 0 in real life, so 0 is a good test of whether it exists! Then we can print a warning on shopt -s dotglob

I also did the same for FNM_EXTMATCH, the extended glob issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants