[builtin/completion_osh] Support SparseArray COMPREPLY and COMP_ARGV #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SparseArray_GetValues is used to obtain comp_argv from the shell variable COMP_ARGV. This ignores all the unset elements and only picks up the set elements. Then the word index would be changed. This might not be desired. Maybe it is better to first convert it to BashArray and use the member strs? * Conversely, when there are unset elements in COMP_ARGV with BashArray, doesn't that cause problems in the later AdjustArg?
akinomyoga
force-pushed
the
SparseArray-compgen
branch
from
df9b56c to
20ecebd
Compare
|
OK thank you, this looks like good progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.