[spec/var-op-bash] Split #24 into respective tests for @Q, @P, and @a
#2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2210 (comment)
I split the test into three, but it seems non-trivial to normalize the results so that the expected STDOUT can be shared. It is because, to normalize the results (particularly for the hash ordering), one needs to assume the form of the results, which is actually the test target. In this PR, I just split the tests and reduced the OK sections for the tests with the common results. I think this is sufficient because it is now easy to compare these smaller OK sections with the corresponding PASS sections.