Clean up oversights and leftovers for array refactoring #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andychu
reviewed
Jan 4, 2025
osh/sh_expr_eval.py
Outdated
| raise error.TypeErr(val, 'Expected BashArray or BashAssoc', | ||
| blame_loc) | ||
| raise error.TypeErr( | ||
| val, 'Expected BashArray, SparseArray, or BashAssoc', |
There was a problem hiding this comment.
We are eventually going to remove change SparseArray -> BashArray, so this change will have to be undone
Since it is a user-facing string
There was a problem hiding this comment.
Even if it would be finally switched, I wanted to carry out the switching in a single consistent commit.
I dropped commit 8e3f4b1. I've already modified the other error messages, but they are not reverted within this PR.
akinomyoga
force-pushed
the
SparseArray-leftover
branch
from
ed5b029 to
9137175
Compare
|
Great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.