test: add tests for cleanup functions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoeffect
requested changes
Dec 7, 2024
There was a problem hiding this comment.
Thank you for the PR @GovardhaneNitin!
This looks almost ready to merge, however, per my comment on your other PR here, this project conforms to StandardJS for its formatting. We don't have this enforced yet (that's issue #5).
Could you please revert all your changes to the formatting (e.g. back to single quotes and no semi-colons)?
|
@taoeffect I've reverted all the formatting changes to conform to StandardJS (single quotes and no semicolons). Please let me know if any further adjustments are needed. |
taoeffect
requested changes
Dec 7, 2024
Sorry, it was the mistake of my IDE. I'm not an AI 😄. |
taoeffect
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tests for Cleanup Functions
This PR adds tests for the cleanup functions in the
onandoncemethods as requested in the review comments of PR #3.Changes Made
onworks correctly.onceworks correctly.These tests have been added to the existing
src/index.test.jsfile.Related Issue
Referencing the original PR #3 for context.
Please let me know if any further adjustments are needed.