Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Pretrained consistent #47

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Makes Pretrained consistent #47

merged 2 commits into from
Nov 18, 2020

Conversation

oke-aditya
Copy link
Owner

Suppresses #33

This does a small refactor for lightning trainers to support pretrained models.

Somehow this issue is not fully resolved. But this at least makes pretrained consistent to str.

We should try to avoid boolean for it.

A complete solution is rather hard. Plus lack of pretrained weights would simply keep creating errors here and there.

If community can contribute resnet_fpn weights. It would be great !! We can then think of adding that feature by changing a bit to the backbone API.

@oke-aditya oke-aditya self-assigned this Nov 18, 2020
@oke-aditya oke-aditya added bug Something isn't working High Priority Should be addressed ASAP. labels Nov 18, 2020
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #47 (bfcf280) into master (06dc0ac) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files          41       41           
  Lines        1372     1372           
=======================================
  Hits         1071     1071           
  Misses        301      301           
Flag Coverage Δ
unittests 78.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quickvision/models/detection/detr/model_factory.py 100.00% <100.00%> (ø)
.../models/detection/faster_rcnn/lightning_trainer.py 100.00% <100.00%> (ø)
...on/models/detection/retinanet/lightning_trainer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06dc0ac...bfcf280. Read the comment docs.

@oke-aditya oke-aditya merged commit 8f6fd6b into oke-aditya:master Nov 18, 2020
@oke-aditya oke-aditya deleted the rf_obj2 branch November 18, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority Should be addressed ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant