Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parallax on hero #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sergiopena
Copy link

Add boolean to set the hero background image as fixed to create a parallax scroll effect.

What this PR does / why we need it:
Adds a nice parallax effect to the Hero partial

Which issue this PR fixes
partially fixes #814

Special notes for your reviewer:
I started learning Hugo and this theme seven hours ago, so I literally don't know what I'm doing.

Just saw that it looked super easy to add a bool to fix the image in the background and get the effect 😇

It works on my computer ™️

Release note:

 parallax effect to hero partial

Add boolean to set the hero background image as fixed creating a parallax scroll effect.
@stp-ip
Copy link
Member

stp-ip commented Aug 14, 2022

Thank you for the addition already.
There are a few missing things.
It isn't documented on the fragment page: https://github.com/okkur/syna/tree/master/exampleSite/content/fragments/hero
Additionally with the default image it seems to not work well. Maybe a two part screenshot attached to the PR showcasing this effect makes this easier to grasp for anyone following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add support for background images and simple parallax scrolling
2 participants