Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Began Swift 3 conversion, outstanding issues with isSelected #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-grindr
Copy link

No description provided.

@siideffect
Copy link

siideffect commented Aug 31, 2016

Hi martin, thanks for the conversion first of all, i use this library on one of my apps on the appstore, so i really needed it. So, you reported some problem with the isSelected variable ( i used your source code, and i experienced problems in my app, and i was not able to deselect the DoFavouriteButton), but after digging into the code, i could notice you (for some reason ) commented out the first line of select() and deselect() methods, which were setting the button selected state.

Actually i am using it in my project and is fully compatible with swift 3, i just had small problems with the cgpath methods, which can be easily solved:
moveTo becomes move( to: CGPoint() )
addLineTo becomes addLine( to: CGPoint() )

Hope it helps, enjoy coding =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants