Implemented VecAssertions for referenced vectors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oknozor
reviewed
Oct 5, 2021
| /// type must be of `&Vec` with a matching lifetime. | ||
| /// | ||
| /// ```rust,ignore | ||
| /// assert_that(&&vec![1, 2, 3, 4]).has_length(4); |
There was a problem hiding this comment.
Can you update the doc tests so it's not being ignored ? This will ensure the doc is always up to date with the actual implementation.
There was a problem hiding this comment.
Done, thanks for the review.
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
- Coverage 96.30% 95.58% -0.72%
==========================================
Files 10 10
Lines 1002 1020 +18
==========================================
+ Hits 965 975 +10
- Misses 37 45 +8
Continue to review full report at Codecov.
|
|
Thanks for the PR @woshilapin , as I mentioned above you need to update the doc so I actually runs some doc-tests, also can you run |
woshilapin
force-pushed
the
unwrapping_vectors
branch
from
66439b0 to
35856a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a transfer of the PR cfrancia/spectral#12 which is coming from the original project
spectral. Thanks to @kirushik for the contribution of code.