Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8: Return reference to self from matches func to enable chaining #9

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

MrTact
Copy link
Contributor

@MrTact MrTact commented Jan 10, 2022

Fixes #8

  • Implementated
  • Test added
  • Documented

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #9 (f58b7d1) into main (3c7c527) will decrease coverage by 3.23%.
The diff coverage is 85.71%.

❗ Current head f58b7d1 differs from pull request most recent head 28820aa. Consider uploading reports for the commit 28820aa to get more accurate results

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   96.76%   93.53%   -3.24%     
==========================================
  Files          10       10              
  Lines        1856     1067     -789     
==========================================
- Hits         1796      998     -798     
- Misses         60       69       +9     
Impacted Files Coverage Δ
src/lib.rs 91.13% <85.71%> (-7.42%) ⬇️
src/hashmap.rs 91.50% <0.00%> (-8.50%) ⬇️
src/numeric.rs 93.61% <0.00%> (-6.39%) ⬇️
src/vec.rs 60.78% <0.00%> (-4.65%) ⬇️
src/option.rs 96.36% <0.00%> (-3.64%) ⬇️
src/string.rs 97.77% <0.00%> (-2.23%) ⬇️
src/result.rs 100.00% <0.00%> (ø)
src/boolean.rs 100.00% <0.00%> (ø)
src/iter.rs 94.35% <0.00%> (+0.22%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@oknozor
Copy link
Owner

oknozor commented Jan 11, 2022

@MrTact thanks for the addition, I think this would fit with #6 .
Maybe we could add a SofSpec struct for this use case to check all match case before returning a global report.

@MrTact
Copy link
Contributor Author

MrTact commented Jan 11, 2022

Will take a look at that. There's no rush, as I have to fix the code coverage before this PR can be merged anyway.

@oknozor oknozor merged commit cc64f77 into oknozor:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have matches() return &mut Self
2 participants