Attempt Python 3.12 support for ok-client #487
Conversation
cycomachead
changed the title
|
@LarynQi Can you or someone else approve my fork to run workflows. :) https://github.com/cs88-website/ok-client/actions/runs/7550596522/job/20556482294 |
| @@ -1,6 +1,6 @@ | |||
| name: CI | |||
|
|
|||
| on: [push, pull_request] | |||
| on: [push, pull_request, workflow_dispatch] | |||
There was a problem hiding this comment.
This allows manually rerunning workflows, which is handy for folks using a fork
| @@ -10,44 +10,44 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| name: [ | |||
| Python 3.12 (Windows), | |||
There was a problem hiding this comment.
3.7 is deprecated, 3.8 will be soon.
I skipped 3.10 since we have 3.11 + 3.12 and it didn't seem worth the CI time. 🤷
(Also so many lines to add!)
| @@ -102,4 +102,4 @@ jobs: | |||
| esac | |||
| . "${VENV_DIR}/${scripts}/activate" | |||
| echo "Using $(python --version) on ${{ matrix.os }}" 1>&2 | |||
| nosetests --traverse-namespace --with-coverage tests | |||
| nose2 -v --with-coverage tests | |||
There was a problem hiding this comment.
-v may not be necessary, but it was helpful to make sure things were running.
I don't know what --traverse-namespace does, but it is not supported in nose2
| @@ -0,0 +1,5 @@ | |||
| "<Mock name='mock.name' id='2137274846528'>-correct", (0, 66) | |||
There was a problem hiding this comment.
Are these necessary?
Seems like not.
| @@ -0,0 +1,3 @@ | |||
| [unittest] | |||
| start-dir = tests | |||
| test-file-pattern = *_test.py | |||
There was a problem hiding this comment.
| test-file-pattern = *_test.py | |
| test-file-pattern = *_test.py | |
however, an error still shows when running/compiling on my machine
|
@cycomachead It would be great to try to get the CI tests to run, but I would prefer to merge this tonight even if we haven't done that, rather than wait. Suggestions? @gabeclasson Any reason why this shouldn't be merged? |
|
We fixed the buildserver yesterday, so maybe just making a trivial change will trigger the build. |
This is just building off Gabe's work. I haven't done any more investigations, but tried to update CI to use recent Python