feat: onAuthExpired callback #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
reviewed
Aug 20, 2021
| const originalUri = toRelativeUrl(window.location.href, window.location.origin); | ||
| oktaAuth.setOriginalUri(originalUri); | ||
|
|
||
| // We have previously signed in | ||
| const hasExpired = hasAuthenticated.current === true; |
There was a problem hiding this comment.
Looks like we are able to detect if it's triggered by initial load or future authState change, how about feeding an extra state object to the onAuthRequiredFn callback, then devs can code based on that?
onAuthRequired(oktaAuth, options /* probably not the best name */)
In this way, we make the workaround possible with a minor change. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
onAuthRequired will be called whenever authState.isAuthenticated switches to false. The default behavior is to call
signinWithRedirect()This causes an (unwanted) redirect after tokens are removed or session expires.Issue Number: OKTA-394440
What is the new behavior?
onAuthRequired will be called ONCE for a SecureRoute. If authState.isAuthenticated toggles to false later, a new callback named "onAuthExpired" will be called BUT the component will be rendered (this is new behavior). The
onAuthExpiredoption can be passed as a prop to Security or SecureRoute.Does this PR introduce a breaking change?
The secure component's children may be rendered even though
oktaAuth.isAuthenticated()returns false. This could break assumptions made by the child component.Other information
Reviewers