Update readme and parameters to they match each other #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| FROM okteto/okteto:latest | |||
| FROM okteto/okteto:2.18.0 | |||
There was a problem hiding this comment.
@jLopezbarb shall we start pinning the version for the actions?
Should we add updating the pinned version as part of the release?
There was a problem hiding this comment.
I think we were going to use:
- main for latest
- v2 for the latest v2
- v1 for the latest v1
If we pin it we would have to change it in every CLI release and we'll need to update the actions script
| @@ -11,10 +11,25 @@ You can use this action to build images from an [Okteto Manifest](https://www.ok | |||
|
|
|||
| ## Inputs | |||
|
|
|||
| ### `tag` | |||
There was a problem hiding this comment.
The inputs where removed as "not suported" although they exist at the actions.yaml in order to preserve compatibility with older workflows
There was a problem hiding this comment.
I think the inputs are for the v1 branch so it depend on how we want to organise the v1 and v2.
v1 had some tags that were retrocompatible with v2.
There was a problem hiding this comment.
all the inputs I added here are active on the latest version of the Okteto CLI. Can we add them here?
|
|
||
| You can specify a custom certificate authority or a self-signed certificate by setting the `OKTETO_CA_CERT` environment variable. When this variable is set, the action will install the certificate in the container, and then execute the action. | ||
| This example sets the context, and then builds an image that is not defined in the Okteto manifest |
There was a problem hiding this comment.
@jLopezbarb do you have context on why tag was not supported anymore with 2.0 change?
There was a problem hiding this comment.
I can't remember. I think it was because with the manifest v2 some flags were skipped so we created v1 and v2 to differentiate between them
rberrelleza
commented
Aug 10, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM okteto/okteto:latest | |||
| FROM okteto/okteto:2.18.0 | |||
There was a problem hiding this comment.
Suggested change
| FROM okteto/okteto:2.18.0 | |
| FROM okteto/okteto:latest |
teresaromero
added a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Teresa Romero <[email protected]>
teresaromero
added a commit
that referenced
this pull request
Sep 13, 2023
* refactor: remove deprecated global argument Signed-off-by: Teresa Romero <[email protected]> * refactor: fix file argument Signed-off-by: Teresa Romero <[email protected]> * refactor: include tag param into Readme and entrypoint Signed-off-by: Teresa Romero <[email protected]> * refactor: include path into command Signed-off-by: Teresa Romero <[email protected]> * docs: README update Signed-off-by: Teresa Romero <[email protected]> * refactor: add buildargs support Signed-off-by: Teresa Romero <[email protected]> * docs: README update based on #17 Signed-off-by: Teresa Romero <[email protected]> * refactor: fix build-args support Signed-off-by: Teresa Romero <[email protected]> * refactor: support other flags for build command Signed-off-by: Teresa Romero <[email protected]> * Apply suggestions from code review Co-authored-by: Andrea Falzetti <[email protected]> --------- Signed-off-by: Teresa Romero <[email protected]> Co-authored-by: Andrea Falzetti <[email protected]>
maroshii
pushed a commit
that referenced
this pull request
Mar 12, 2024
* refactor: remove deprecated global argument Signed-off-by: Teresa Romero <[email protected]> * refactor: fix file argument Signed-off-by: Teresa Romero <[email protected]> * refactor: include tag param into Readme and entrypoint Signed-off-by: Teresa Romero <[email protected]> * refactor: include path into command Signed-off-by: Teresa Romero <[email protected]> * docs: README update Signed-off-by: Teresa Romero <[email protected]> * refactor: add buildargs support Signed-off-by: Teresa Romero <[email protected]> * docs: README update based on #17 Signed-off-by: Teresa Romero <[email protected]> * refactor: fix build-args support Signed-off-by: Teresa Romero <[email protected]> * refactor: support other flags for build command Signed-off-by: Teresa Romero <[email protected]> * Apply suggestions from code review Co-authored-by: Andrea Falzetti <[email protected]> --------- Signed-off-by: Teresa Romero <[email protected]> Co-authored-by: Andrea Falzetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.