Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing; render config yaml files as erb templates #95

Merged
merged 7 commits into from
Apr 20, 2024

Conversation

rrevi
Copy link
Contributor

@rrevi rrevi commented Feb 29, 2024

No description provided.

@rrevi
Copy link
Contributor Author

rrevi commented Feb 29, 2024

Hi @oldmoe , I plan to add the support to render config yaml files as erb templates; but before I do, I needed to fix failing tests 😄

@rrevi rrevi changed the title Fix testing Fix testing; render config yaml files as erb templates Mar 1, 2024
@rrevi
Copy link
Contributor Author

rrevi commented Mar 1, 2024

@oldmoe not to state the obvious, but I've added render of config yaml files as erb templates to this PR

@rossta rossta mentioned this pull request Mar 2, 2024
3 tasks
@oldmoe
Copy link
Owner

oldmoe commented Apr 20, 2024

Thanks a lot rrevi for this, it should close a couple issues!

@oldmoe oldmoe merged commit a01a616 into oldmoe:master Apr 20, 2024
0 of 3 checks passed
@rrevi rrevi deleted the fix-testing branch April 20, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants