borders: allow customization of corners #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brutasse
force-pushed
the
feature/more-separators
branch
from
05c4b6d to
064dad9
Compare
brutasse
force-pushed
the
feature/more-separators
branch
from
064dad9 to
4cef6bb
Compare
1 task
|
I wonder that this work correctly on CJK locales. The border character is assinged as East Asian Ambiguous Widths. |
|
@mattn can we verify? |
|
I wonder what #115 is different from this PR. cc: @jfromaniello |
|
#155 seems to me more straight forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this is similar to #115, although slightly lower-level. Current rendering behavior is unchanged (no existing tests were changed). This allows using unicode corner characters for nicer rendering.