ENH: check_exp_ad restricted to real groups

olivierverdier · Oct 21, 2024 · a3bd7a9 · a3bd7a9
1 parent e52285c
commit a3bd7a9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+- `check_exp_ad` restricted to real groups
+
 ## [0.2.3]
 
 ### Added

diff --git a/src/Group.jl b/src/Group.jl
@@ -15,7 +15,7 @@ for testing Lie groups.
 where the second exponential is the matrix exponential for the
 linear operator ``ξ ↦ [ξ_1, ξ]``.
 """
-function check_exp_ad(G, ξ_1, ξ_2)
+function check_exp_ad(G::AbstractDecoratorManifold{ℝ}, ξ_1, ξ_2)
     χ = exp_lie(G, ξ_1)
     Ad_exp = adjoint_action(G, χ, ξ_2)
 

diff --git a/test/test_group.jl b/test/test_group.jl
@@ -17,7 +17,11 @@ alg_rep(::Any, x) = x
     @test GT.check_grp_rep_compose(G, grp_rep, χ1, χ2)
     @test GT.check_alg_rep(G, alg_rep, ξ1, ξ2)
     @test GT.check_zero_Identity(G) broken=true # fails for SpecialOrthogonal
-    Test.@test GT.check_exp_ad(G, ξ1, ξ2) broken=G isa AbstractDecoratorManifold{ℂ}
+    if G isa AbstractDecoratorManifold{ℂ}
+        @test_throws MethodError GT.check_exp_ad(G, ξ1, ξ2)
+    else
+        @test GT.check_exp_ad(G, ξ1, ξ2)
+    end
     @test GT.check_adjoint_action(G, grp_rep, alg_rep, χ1, ξ1)
     @test GT.check_inv_rep(G, grp_rep, χ1)
     @testset "$side" for side in [LeftSide(), RightSide()]