Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row column names #35

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Row column names #35

merged 4 commits into from
Oct 23, 2020

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Oct 22, 2020

Add acquisition, row and column names to the metadata.

Example:

> cat 51.zarr/.zattrs 
{
    "plate": {
        "col_names": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12
        ],
        "columns": 12,
        "plateAcquisitions": {
            "path": "Run 51"
        },
        "row_names": [
            "F",
            "E",
            "H",
            "A",
            "G",
            "B",
            "D",
            "C"
        ],
        "rows": 8
    }
}

Shall I rather 'break' the previous code and use rows instead of row_names?

Addresses #31 .

/cc @will-moore

@joshmoore
Copy link
Member

NB: I'd suggest running pre-commit install so that when you go to commit, you will be reminded to cleanup before committing so we don't end up with the extra "cleanup" commits.

@will-moore
Copy link
Member

@dominikl I think that for consistency maybe plateAcquisitions should be a list like datasets is for image like:

"plateAcquisitions": [
                {
                    "path": "0"
                },
                {
                    "path": "1"
                },
                {
                    "path": "2"
                },
                {
                    "path": "3"
                },
                {
                    "path": "4"
                }
            ],

Also, if we want to add other info for each plateAcquisition, then this can be added without breaking anything.

@dominikl
Copy link
Member Author

@dominikl I think that for consistency maybe plateAcquisitions should be a list like datasets is for image like:

Yes, I just realized that it doesn't make sense how I add the plateAcquisitions and image data at the moment.

@dominikl dominikl marked this pull request as ready for review October 23, 2020 14:59
@will-moore
Copy link
Member

Tested locally. Looks good to me. 👍

@joshmoore joshmoore merged commit 310243e into ome:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants