Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/except around submit() to handle failures #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

will-moore
Copy link
Member

Fixes #11.

This first commit does the minimum requested by @pwalczysko of simply not failing if the DiskUsage submit failed.

Happy to also add an option to specify the timeout as suggested by @joshmoore.
But just wondering what the 500 loops means at https://github.com/ome/omero-demo-cleanup/blob/main/src/omero_demo_cleanup/library.py#L118 ?

Is that 500 pings to wait for a result - and how long between each one?
E.g. If a user were to enter their own value, would this look like a --loops parameter? Would anyone know what that means? Or would we go for --seconds parameter for how long to wait? And how does this map to loops?

@jburel jburel closed this Jan 30, 2024
@jburel jburel reopened this Jan 30, 2024
@jburel
Copy link
Member

jburel commented Jan 30, 2024

@will-moore could you fix the flake8 issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch timeouts
2 participants