Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README #515

Closed
wants to merge 10 commits into from
Closed

update README #515

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb007dc
update README
will-moore Sep 8, 2023
9c5110e
Dockerfile to use omero-web-standalone:5.21.0 for Django 3.6
will-moore Sep 8, 2023
43e4aee
Use OMEROHOST env name
will-moore Sep 12, 2023
e264b8b
Further tweaks to Docker instructions in README. Use omero-web-standa…
will-moore Dec 8, 2023
257f00d
Use FROM openmicroscopy/omero-web-standalone:5.21.0 Dockerfile
will-moore Dec 14, 2023
f35ae2e
remove 'without installing anything'
will-moore Dec 15, 2023
6b9416e
Clarify usage of grunt with Docker
will-moore Dec 15, 2023
ec524fb
More README Docker info tweaks
will-moore Dec 18, 2023
2659ac0
Add note to run docker in a different terminal after grunt watch
will-moore Jan 3, 2024
a6940e1
Run grunt in different terminal that doesn't have OMEROHOST
will-moore Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ You can refresh the Docker hosted page at http://localhost:4080/figure to see ch
$ cd /PATH_TO_GIT_REPO/omero-figure
$ grunt build
$ grunt watch # to see updates
will-moore marked this conversation as resolved.
Show resolved Hide resolved

# in a different terminal...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the cmd below you are using the OMEROHOST variable which was defined in the previous terminal. Maybe move the OMEROHOST definition to here instead ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwalczysko instead, I switched the order you launch these so that grunt is in a different terminal and you launch docker first in the terminal that does have OMEROHOST - see a6940e1

$ docker run -ti -e OMEROHOST -p 4080:4080 -v /PATH_TO_GIT_REPO/omero-figure:/home/figure/src figure-devel
will-moore marked this conversation as resolved.
Show resolved Hide resolved


Expand Down
Loading