Manual zoom level

[Rdornier]

Hello,

I try to make to necessary changes to add manually the zoom level (fix part of #428).
However, I struggle a lot to test the changes in my dev env (i.e. changes in the code are not always taken into account when I test them).
So, feel free to test and to give me feedback.

Rémy.

[will-moore]

Hi @Rdornier - see Rdornier#1 for some fixes

[Rdornier]

Hi @will-moore

Many thanks for your corrective input ; it perfectly works 👍 !
I've added few more lines to update the image in the figure.
I tested it and it work fine for me.

[will-moore]

@Rdornier Just testing this, and I realise that the value never gets converted from a string to an Integer.
JavaScript works OK with the string as it casts it on the fly for e.g. value < minVal etc.
But when we save it to Figure JSON model, it gets saved as a string (since we don't have any validation of the model).
This means that when you subsequently select multiple panels, the average zoom values aren't calculated properly. E.g. "100" + "200" = "100200" !

[Rdornier]

@will-moore Ok, I've just added a commit to convert the value coming from the UI from string to int (in the listener function and the slider implementation)

[will-moore]

Looking good - I think it could do with a CSS tweak. Trying this:

$ git diff
diff --git a/omero_figure/static/figure/css/figure.css b/omero_figure/static/figure/css/figure.css
index 332b657..ad108bb 100644
--- a/omero_figure/static/figure/css/figure.css
+++ b/omero_figure/static/figure/css/figure.css
@@ -233,6 +233,11 @@
         height: 14px;
         border-radius: 5px;
     }
+    #vp_zoom_value {
+        float: right;
+        width: 50px;
+        margin-top: 5px;
+    }
     .toggle_channel {

gives a nicer layout:

[will-moore]

Thanks!

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-figure-crop-uses-original-image-aspect-ratio-after-rotation/89444/2