-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multiple Languages #689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katajakasa
reviewed
Oct 27, 2024
Nopey
force-pushed
the
language
branch
2 times, most recently
from
October 27, 2024 17:32
4e67d76
to
e4aebfb
Compare
Vagabond
reviewed
Oct 27, 2024
I've been trying to use this to actually switch over to more of the english.dat strings and there's several issues with using them more extensively:
Given we also have missing strings already, and some of these strings seem kind of redundant and tied to quirks of the original engine, we may wish to create entirely new translation files, derived from the originals? |
Nopey
force-pushed
the
language
branch
15 times, most recently
from
November 1, 2024 00:17
4d0b317
to
39cd667
Compare
mrannanj
requested changes
Nov 1, 2024
Nopey
force-pushed
the
language
branch
2 times, most recently
from
November 1, 2024 23:06
caf5fc2
to
82dd381
Compare
This was referenced Nov 2, 2024
For some reason Windows was matching DANISH.LNG2 to \*.LNG
mrannanj
requested changes
Nov 2, 2024
U+2302 is what CP 234 has at 0x7F, and although OMF uses 0x7F slightly differently-- this is probably easiest.
mrannanj
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Configuration option "LANGUAGE" lets player choose their language.
Older, 990-string-long localization files (like german.dat) are supported by inserting empty dummy entries where OMFv2.1 (the netplay update) added new strings.
Issues that remain:
Obsoletes PR #508 and includes PR #693